diff options
author | xuri <xuri.me@gmail.com> | 2019-08-08 09:47:00 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-08-08 09:47:00 +0800 |
commit | 448f5524a8ea621fd40978dcc518ff6d9bbcdf83 (patch) | |
tree | 68a039a7d419e8805d89b8b2028c7b0f519bc7b6 | |
parent | d8df51098f11eaa520112c6d043509b893bf0097 (diff) | |
parent | e07581e980444b64bc15fce328ff07736ac9dbf6 (diff) |
Merge pull request #461 from mlh758/fix-439
Further improve read performance
-rw-r--r-- | excelize_test.go | 6 | ||||
-rw-r--r-- | rows.go | 4 |
2 files changed, 7 insertions, 3 deletions
diff --git a/excelize_test.go b/excelize_test.go index 79010b1..4169983 100644 --- a/excelize_test.go +++ b/excelize_test.go @@ -1003,7 +1003,11 @@ func TestSharedStrings(t *testing.T) { if !assert.NoError(t, err) { t.FailNow() } - f.GetRows("Sheet1") + rows, err := f.GetRows("Sheet1") + if !assert.NoError(t, err) { + t.FailNow() + } + assert.Equal(t, "A", rows[0][0]) } func TestSetSheetRow(t *testing.T) { @@ -112,8 +112,8 @@ func (f *File) Rows(sheet string) (*Rows, error) { return nil, ErrSheetNotExist{sheet} } if xlsx != nil { - output, _ := xml.Marshal(f.Sheet[name]) - f.saveFileList(name, replaceWorkSheetsRelationshipsNameSpaceBytes(output)) + data := f.readXML(name) + f.saveFileList(name, replaceWorkSheetsRelationshipsNameSpaceBytes(namespaceStrictToTransitional(data))) } return &Rows{ f: f, |