diff options
| author | yuki2006 <yagfair@gmail.com> | 2021-03-04 10:23:45 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-04 09:23:45 +0800 |
| commit | dbe88d723ef8ab3d2fbb1b94aa4c5b2486b0e679 (patch) | |
| tree | 88535cf029d06acdd2fe1fb43bc8a1ac24896c96 | |
| parent | a12dfd3ce6402f22baeb6415af271d8545c74f71 (diff) | |
Fix UpdateLinkedValue which returns an error when has graph sheet (#793)
* Fixed UpdateLinkedValue which returns an error when there is a graph sheet
Signed-off-by: yuuki.ono <yagfair@gmail.com>
* fix refactoring from review
Signed-off-by: yuuki.ono <yagfair@gmail.com>
| -rw-r--r-- | chart_test.go | 2 | ||||
| -rw-r--r-- | excelize.go | 3 |
2 files changed, 5 insertions, 0 deletions
diff --git a/chart_test.go b/chart_test.go index 9bbc06d..6ee0a0f 100644 --- a/chart_test.go +++ b/chart_test.go @@ -236,6 +236,8 @@ func TestAddChartSheet(t *testing.T) { // Test with unsupported chart type assert.EqualError(t, f.AddChartSheet("Chart2", `{"type":"unknown","series":[{"name":"Sheet1!$A$2","categories":"Sheet1!$B$1:$D$1","values":"Sheet1!$B$2:$D$2"},{"name":"Sheet1!$A$3","categories":"Sheet1!$B$1:$D$1","values":"Sheet1!$B$3:$D$3"},{"name":"Sheet1!$A$4","categories":"Sheet1!$B$1:$D$1","values":"Sheet1!$B$4:$D$4"}],"title":{"name":"Fruit 3D Clustered Column Chart"}}`), "unsupported chart type unknown") + assert.NoError(t, f.UpdateLinkedValue()) + assert.NoError(t, f.SaveAs(filepath.Join("test", "TestAddChartSheet.xlsx"))) } diff --git a/excelize.go b/excelize.go index a38a745..f45dcc0 100644 --- a/excelize.go +++ b/excelize.go @@ -314,6 +314,9 @@ func (f *File) UpdateLinkedValue() error { for _, name := range f.GetSheetList() { xlsx, err := f.workSheetReader(name) if err != nil { + if err.Error() == fmt.Sprintf("sheet %s is chart sheet", trimSheetName(name)) { + continue + } return err } for indexR := range xlsx.SheetData.Row { |