summaryrefslogtreecommitdiff
path: root/comment.go
diff options
context:
space:
mode:
authorEng Zer Jun <engzerjun@gmail.com>2022-06-12 00:19:12 +0800
committerGitHub <noreply@github.com>2022-06-12 00:19:12 +0800
commit6bcf5e4ede160af2ad04f5e69636211a5ced132d (patch)
tree836568f4c83f24d87acbd26f172f967c7a6a1118 /comment.go
parentf5d3d59d8c65d9396893ae0156fef21592f6f425 (diff)
refactor: replace strings.Replace with strings.ReplaceAll (#1250)
strings.ReplaceAll(s, old, new) is a wrapper function for strings.Replace(s, old, new, -1). But strings.ReplaceAll is more readable and removes the hardcoded -1. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Diffstat (limited to 'comment.go')
-rw-r--r--comment.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/comment.go b/comment.go
index a7c1415..0e3945d 100644
--- a/comment.go
+++ b/comment.go
@@ -112,7 +112,7 @@ func (f *File) AddComment(sheet, cell, format string) error {
// The worksheet already has a comments relationships, use the relationships drawing ../drawings/vmlDrawing%d.vml.
sheetRelationshipsDrawingVML = f.getSheetRelationshipsTargetByID(sheet, ws.LegacyDrawing.RID)
commentID, _ = strconv.Atoi(strings.TrimSuffix(strings.TrimPrefix(sheetRelationshipsDrawingVML, "../drawings/vmlDrawing"), ".vml"))
- drawingVML = strings.Replace(sheetRelationshipsDrawingVML, "..", "xl", -1)
+ drawingVML = strings.ReplaceAll(sheetRelationshipsDrawingVML, "..", "xl")
} else {
// Add first comment for given sheet.
sheetRels := "xl/worksheets/_rels/" + strings.TrimPrefix(f.sheetMap[trimSheetName(sheet)], "xl/worksheets/") + ".rels"