diff options
| author | dafengge0913 <dafengge0913@hotmail.com> | 2022-09-10 13:05:34 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-10 13:05:34 +0800 |
| commit | c72fb747b8a64117538229f1e5a85d220349b6f1 (patch) | |
| tree | 9548497d4f23b34f1e2144c07aff1e07f98942cb /comment_test.go | |
| parent | fb1aab7add52808c96c9cc10570fe73ce797b7f4 (diff) | |
Fix DeleteComment slice bounds out of range (#1343)
Diffstat (limited to 'comment_test.go')
| -rw-r--r-- | comment_test.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/comment_test.go b/comment_test.go index 64e9968..0d1e039 100644 --- a/comment_test.go +++ b/comment_test.go @@ -55,15 +55,19 @@ func TestDeleteComment(t *testing.T) { assert.NoError(t, f.AddComment("Sheet2", "A40", `{"author":"Excelize: ","text":"This is a comment1."}`)) assert.NoError(t, f.AddComment("Sheet2", "A41", `{"author":"Excelize: ","text":"This is a comment2."}`)) assert.NoError(t, f.AddComment("Sheet2", "C41", `{"author":"Excelize: ","text":"This is a comment3."}`)) + assert.NoError(t, f.AddComment("Sheet2", "C41", `{"author":"Excelize: ","text":"This is a comment3-1."}`)) + assert.NoError(t, f.AddComment("Sheet2", "C42", `{"author":"Excelize: ","text":"This is a comment4."}`)) + assert.NoError(t, f.AddComment("Sheet2", "C41", `{"author":"Excelize: ","text":"This is a comment3-2."}`)) assert.NoError(t, f.DeleteComment("Sheet2", "A40")) - assert.EqualValues(t, 2, len(f.GetComments()["Sheet2"])) + assert.EqualValues(t, 5, len(f.GetComments()["Sheet2"])) assert.EqualValues(t, len(NewFile().GetComments()), 0) // Test delete all comments in a worksheet assert.NoError(t, f.DeleteComment("Sheet2", "A41")) assert.NoError(t, f.DeleteComment("Sheet2", "C41")) + assert.NoError(t, f.DeleteComment("Sheet2", "C42")) assert.EqualValues(t, 0, len(f.GetComments()["Sheet2"])) // Test delete comment on not exists worksheet assert.EqualError(t, f.DeleteComment("SheetN", "A1"), "sheet SheetN does not exist") |