summaryrefslogtreecommitdiff
path: root/merge_test.go
diff options
context:
space:
mode:
authorxuri <xuri.me@gmail.com>2021-08-15 00:06:40 +0800
committerxuri <xuri.me@gmail.com>2021-08-15 00:06:40 +0800
commit48c16de8bf74df0fa94a30d29e2e7e3446d48433 (patch)
tree329a2e4ab896982581bd348a1700d75aeb40a517 /merge_test.go
parentf6f14f507ee1adf4883cb1b12f27932a63afb286 (diff)
Improve security and simplify code
- Make variable name more semantic - Reduce cyclomatic complexities for the formula calculate function - Support specified unzip size limit on open file options, avoid zip bombs vulnerability attack - Typo fix for documentation and error message
Diffstat (limited to 'merge_test.go')
-rw-r--r--merge_test.go6
1 files changed, 3 insertions, 3 deletions
diff --git a/merge_test.go b/merge_test.go
index a370126..02d92fb 100644
--- a/merge_test.go
+++ b/merge_test.go
@@ -148,16 +148,16 @@ func TestUnmergeCell(t *testing.T) {
}
sheet1 := f.GetSheetName(0)
- xlsx, err := f.workSheetReader(sheet1)
+ sheet, err := f.workSheetReader(sheet1)
assert.NoError(t, err)
- mergeCellNum := len(xlsx.MergeCells.Cells)
+ mergeCellNum := len(sheet.MergeCells.Cells)
assert.EqualError(t, f.UnmergeCell("Sheet1", "A", "A"), `cannot convert cell "A" to coordinates: invalid cell name "A"`)
// unmerge the mergecell that contains A1
assert.NoError(t, f.UnmergeCell(sheet1, "A1", "A1"))
- if len(xlsx.MergeCells.Cells) != mergeCellNum-1 {
+ if len(sheet.MergeCells.Cells) != mergeCellNum-1 {
t.FailNow()
}