Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | Huge refactorig for consistent col/row numbering (#356) | Veniamin Albaev | 2019-03-20 |
| | | | | | | | | | | | | | | | | | | | * Huge refactorig for consistent col/row numbering Started from simply changing ToALphaString()/TitleToNumber() logic and related fixes. But have to go deeper, do fixes, after do related fixes and again and again. Major improvements: 1. Tests made stronger again (But still be weak). 2. "Empty" returns for incorrect input replaces with panic. 3. Check for correct col/row/cell naming & addressing by default. 4. Removed huge amount of duplicated code. 5. Removed ToALphaString(), TitleToNumber() and it helpers functions at all, and replaced with SplitCellName(), JoinCellName(), ColumnNameToNumber(), ColumnNumberToName(), CellNameToCoordinates(), CoordinatesToCellName(). 6. Minor fixes for internal variable naming for code readability (ex. col, row for input params, colIdx, rowIdx for slice indexes etc). * Formatting fixes | ||
* | update go test and function docs | caozhiyi | 2019-03-07 |
| | |||
* | Implement consistent row addressing by Excel row number starting with 1 (#350) | Veniamin Albaev | 2019-03-06 |
| | | | | | | | | | | | | | | | * Implement consistent row addressing by Excel row number starting with 1 1. Added second versions for all row manipulation methods with zero-based row addressing. 2. Fixed methods documentation to explicitly describe which row addressing used in method. 3. Added WARNING to README.md. 4. Cosmetic change: All row test moved to file `rows_test.go`. * TravisCI: go1.12 added to tests matrix * BACKWARD INCOMPARTIBLE: Use only Excel numbering logic from 1 row * README updated | ||
* | Merge test cases and use strict error checking. | Ri Xu | 2018-05-07 |
| | |||
* | add iterator method for rows | Lunny Xiao | 2018-05-05 |