From b96329cc88b87da25a4389f1d4d5ad08cd40605a Mon Sep 17 00:00:00 2001 From: xuri Date: Wed, 12 Jan 2022 00:18:15 +0800 Subject: Breaking change for data validation and fixed #1117 - Remove second useless parameter `isCurrentSheet` of the function `SetSqrefDropList` - Fix missing page setup of worksheet after re-saving the spreadsheet --- datavalidation.go | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'datavalidation.go') diff --git a/datavalidation.go b/datavalidation.go index 4b0c4f3..c8c9141 100644 --- a/datavalidation.go +++ b/datavalidation.go @@ -168,16 +168,12 @@ func (dd *DataValidation) SetRange(f1, f2 interface{}, t DataValidationType, o D // // dvRange := excelize.NewDataValidation(true) // dvRange.Sqref = "A7:B8" -// dvRange.SetSqrefDropList("$E$1:$E$3", true) +// dvRange.SetSqrefDropList("$E$1:$E$3") // f.AddDataValidation("Sheet1", dvRange) // -func (dd *DataValidation) SetSqrefDropList(sqref string, isCurrentSheet bool) error { - if isCurrentSheet { - dd.Formula1 = fmt.Sprintf("%s", sqref) - dd.Type = convDataValidationType(typeList) - return nil - } - return fmt.Errorf("cross-sheet sqref cell are not supported") +func (dd *DataValidation) SetSqrefDropList(sqref string) { + dd.Formula1 = fmt.Sprintf("%s", sqref) + dd.Type = convDataValidationType(typeList) } // SetSqref provides function to set data validation range in drop list. -- cgit v1.2.1