From b96329cc88b87da25a4389f1d4d5ad08cd40605a Mon Sep 17 00:00:00 2001 From: xuri Date: Wed, 12 Jan 2022 00:18:15 +0800 Subject: Breaking change for data validation and fixed #1117 - Remove second useless parameter `isCurrentSheet` of the function `SetSqrefDropList` - Fix missing page setup of worksheet after re-saving the spreadsheet --- datavalidation_test.go | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'datavalidation_test.go') diff --git a/datavalidation_test.go b/datavalidation_test.go index 403cb15..eed1b03 100644 --- a/datavalidation_test.go +++ b/datavalidation_test.go @@ -81,15 +81,12 @@ func TestDataValidationError(t *testing.T) { dvRange := NewDataValidation(true) dvRange.SetSqref("A7:B8") dvRange.SetSqref("A7:B8") - assert.NoError(t, dvRange.SetSqrefDropList("$E$1:$E$3", true)) - - err := dvRange.SetSqrefDropList("$E$1:$E$3", false) - assert.EqualError(t, err, "cross-sheet sqref cell are not supported") + dvRange.SetSqrefDropList("$E$1:$E$3") assert.NoError(t, f.AddDataValidation("Sheet1", dvRange)) dvRange = NewDataValidation(true) - err = dvRange.SetDropList(make([]string, 258)) + err := dvRange.SetDropList(make([]string, 258)) if dvRange.Formula1 != "" { t.Errorf("data validation error. Formula1 must be empty!") return -- cgit v1.2.1