From 48c16de8bf74df0fa94a30d29e2e7e3446d48433 Mon Sep 17 00:00:00 2001 From: xuri Date: Sun, 15 Aug 2021 00:06:40 +0800 Subject: Improve security and simplify code - Make variable name more semantic - Reduce cyclomatic complexities for the formula calculate function - Support specified unzip size limit on open file options, avoid zip bombs vulnerability attack - Typo fix for documentation and error message --- file_test.go | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'file_test.go') diff --git a/file_test.go b/file_test.go index d86ce53..956ff92 100644 --- a/file_test.go +++ b/file_test.go @@ -37,9 +37,7 @@ func BenchmarkWrite(b *testing.B) { func TestWriteTo(t *testing.T) { // Test WriteToBuffer err { - f := File{} - buf := bytes.Buffer{} - f.Pkg = sync.Map{} + f, buf := File{Pkg: sync.Map{}}, bytes.Buffer{} f.Pkg.Store("/d/", []byte("s")) _, err := f.WriteTo(bufio.NewWriter(&buf)) assert.EqualError(t, err, "zip: write to directory") @@ -47,9 +45,7 @@ func TestWriteTo(t *testing.T) { } // Test file path overflow { - f := File{} - buf := bytes.Buffer{} - f.Pkg = sync.Map{} + f, buf := File{Pkg: sync.Map{}}, bytes.Buffer{} const maxUint16 = 1<<16 - 1 f.Pkg.Store(strings.Repeat("s", maxUint16+1), nil) _, err := f.WriteTo(bufio.NewWriter(&buf)) @@ -57,9 +53,7 @@ func TestWriteTo(t *testing.T) { } // Test StreamsWriter err { - f := File{} - buf := bytes.Buffer{} - f.Pkg = sync.Map{} + f, buf := File{Pkg: sync.Map{}}, bytes.Buffer{} f.Pkg.Store("s", nil) f.streams = make(map[string]*StreamWriter) file, _ := os.Open("123") -- cgit v1.2.1