From 7f78464f7f6ecd87c5f5c53d7c00320fd53c4a03 Mon Sep 17 00:00:00 2001
From: xuri <xuri.me@gmail.com>
Date: Sat, 23 May 2020 13:29:51 +0800
Subject: add test for ReadZipReader, close #642

---
 lib.go | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

(limited to 'lib.go')

diff --git a/lib.go b/lib.go
index 5b7e6d0..91b3635 100644
--- a/lib.go
+++ b/lib.go
@@ -15,7 +15,6 @@ import (
 	"container/list"
 	"fmt"
 	"io"
-	"log"
 	"strconv"
 	"strings"
 	"unsafe"
@@ -59,7 +58,6 @@ func (f *File) saveFileList(name string, content []byte) {
 func readFile(file *zip.File) ([]byte, error) {
 	rc, err := file.Open()
 	if err != nil {
-		log.Println(err)
 		return nil, err
 	}
 	dat := make([]byte, 0, file.FileInfo().Size())
@@ -176,11 +174,7 @@ func CellNameToCoordinates(cell string) (int, int, error) {
 	}
 
 	col, err := ColumnNameToNumber(colname)
-	if err != nil {
-		return -1, -1, fmt.Errorf(msg, cell, err)
-	}
-
-	return col, row, nil
+	return col, row, err
 }
 
 // CoordinatesToCellName converts [X, Y] coordinates to alpha-numeric cell
@@ -195,11 +189,7 @@ func CoordinatesToCellName(col, row int) (string, error) {
 		return "", fmt.Errorf("invalid cell coordinates [%d, %d]", col, row)
 	}
 	colname, err := ColumnNumberToName(col)
-	if err != nil {
-		// Error should never happens here.
-		return "", fmt.Errorf("invalid cell coordinates [%d, %d]: %v", col, row, err)
-	}
-	return fmt.Sprintf("%s%d", colname, row), nil
+	return fmt.Sprintf("%s%d", colname, row), err
 }
 
 // boolPtr returns a pointer to a bool with the given value.
-- 
cgit v1.2.1