From ac564afa56a691e378ab9bb04cb14bb283886a16 Mon Sep 17 00:00:00 2001 From: xuri Date: Sun, 13 Nov 2022 00:40:04 +0800 Subject: Remove internal error log print, throw XML deserialize error --- rows_test.go | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) (limited to 'rows_test.go') diff --git a/rows_test.go b/rows_test.go index 5317c22..2e49c28 100644 --- a/rows_test.go +++ b/rows_test.go @@ -235,9 +235,20 @@ func TestSharedStringsReader(t *testing.T) { f := NewFile() // Test read shared string with unsupported charset. f.Pkg.Store(defaultXMLPathSharedStrings, MacintoshCyrillicCharset) - f.sharedStringsReader() - si := xlsxSI{} - assert.EqualValues(t, "", si.String()) + _, err := f.sharedStringsReader() + assert.EqualError(t, err, "XML syntax error on line 1: invalid UTF-8") + // Test read shared strings with unsupported charset content types. + f = NewFile() + f.ContentTypes = nil + f.Pkg.Store(defaultXMLPathContentTypes, MacintoshCyrillicCharset) + _, err = f.sharedStringsReader() + assert.EqualError(t, err, "XML syntax error on line 1: invalid UTF-8") + // Test read shared strings with unsupported charset workbook relationships. + f = NewFile() + f.Relationships.Delete(defaultXMLPathWorkbookRels) + f.Pkg.Store(defaultXMLPathWorkbookRels, MacintoshCyrillicCharset) + _, err = f.sharedStringsReader() + assert.EqualError(t, err, "XML syntax error on line 1: invalid UTF-8") } func TestRowVisibility(t *testing.T) { -- cgit v1.2.1