From a88459d5f1e83006ba421f334a1513d1c231eb6b Mon Sep 17 00:00:00 2001
From: xuri <xuri.me@gmail.com>
Date: Tue, 16 Apr 2019 10:57:21 +0800
Subject: add unit tests to functions

---
 sheet_test.go | 50 +++++++++++++++++++++-----------------------------
 1 file changed, 21 insertions(+), 29 deletions(-)

(limited to 'sheet_test.go')

diff --git a/sheet_test.go b/sheet_test.go
index 1307dc5..7db982a 100644
--- a/sheet_test.go
+++ b/sheet_test.go
@@ -11,7 +11,6 @@ import (
 
 func ExampleFile_SetPageLayout() {
 	xl := excelize.NewFile()
-	const sheet = "Sheet1"
 
 	if err := xl.SetPageLayout(
 		"Sheet1",
@@ -30,7 +29,6 @@ func ExampleFile_SetPageLayout() {
 
 func ExampleFile_GetPageLayout() {
 	xl := excelize.NewFile()
-	const sheet = "Sheet1"
 	var (
 		orientation excelize.PageLayoutOrientation
 		paperSize   excelize.PageLayoutPaperSize
@@ -73,38 +71,24 @@ func TestPageLayoutOption(t *testing.T) {
 
 			xl := excelize.NewFile()
 			// Get the default value
-			if !assert.NoError(t, xl.GetPageLayout(sheet, def), opt) {
-				t.FailNow()
-			}
+			assert.NoError(t, xl.GetPageLayout(sheet, def), opt)
 			// Get again and check
-			if !assert.NoError(t, xl.GetPageLayout(sheet, val1), opt) {
-				t.FailNow()
-			}
+			assert.NoError(t, xl.GetPageLayout(sheet, val1), opt)
 			if !assert.Equal(t, val1, def, opt) {
 				t.FailNow()
 			}
 			// Set the same value
-			if !assert.NoError(t, xl.SetPageLayout(sheet, val1), opt) {
-				t.FailNow()
-			}
+			assert.NoError(t, xl.SetPageLayout(sheet, val1), opt)
 			// Get again and check
-			if !assert.NoError(t, xl.GetPageLayout(sheet, val1), opt) {
-				t.FailNow()
-			}
+			assert.NoError(t, xl.GetPageLayout(sheet, val1), opt)
 			if !assert.Equal(t, val1, def, "%T: value should not have changed", opt) {
 				t.FailNow()
 			}
 			// Set a different value
-			if !assert.NoError(t, xl.SetPageLayout(sheet, test.nonDefault), opt) {
-				t.FailNow()
-			}
-			if !assert.NoError(t, xl.GetPageLayout(sheet, val1), opt) {
-				t.FailNow()
-			}
+			assert.NoError(t, xl.SetPageLayout(sheet, test.nonDefault), opt)
+			assert.NoError(t, xl.GetPageLayout(sheet, val1), opt)
 			// Get again and compare
-			if !assert.NoError(t, xl.GetPageLayout(sheet, val2), opt) {
-				t.FailNow()
-			}
+			assert.NoError(t, xl.GetPageLayout(sheet, val2), opt)
 			if !assert.Equal(t, val1, val2, "%T: value should not have changed", opt) {
 				t.FailNow()
 			}
@@ -113,15 +97,23 @@ func TestPageLayoutOption(t *testing.T) {
 				t.FailNow()
 			}
 			// Restore the default value
-			if !assert.NoError(t, xl.SetPageLayout(sheet, def), opt) {
-				t.FailNow()
-			}
-			if !assert.NoError(t, xl.GetPageLayout(sheet, val1), opt) {
-				t.FailNow()
-			}
+			assert.NoError(t, xl.SetPageLayout(sheet, def), opt)
+			assert.NoError(t, xl.GetPageLayout(sheet, val1), opt)
 			if !assert.Equal(t, def, val1) {
 				t.FailNow()
 			}
 		})
 	}
 }
+
+func TestSetPageLayout(t *testing.T) {
+	f := excelize.NewFile()
+	// Test set page layout on not exists worksheet.
+	assert.EqualError(t, f.SetPageLayout("SheetN"), "sheet SheetN is not exist")
+}
+
+func TestGetPageLayout(t *testing.T) {
+	f := excelize.NewFile()
+	// Test get page layout on not exists worksheet.
+	assert.EqualError(t, f.GetPageLayout("SheetN"), "sheet SheetN is not exist")
+}
-- 
cgit v1.2.1