From 48c16de8bf74df0fa94a30d29e2e7e3446d48433 Mon Sep 17 00:00:00 2001 From: xuri Date: Sun, 15 Aug 2021 00:06:40 +0800 Subject: Improve security and simplify code - Make variable name more semantic - Reduce cyclomatic complexities for the formula calculate function - Support specified unzip size limit on open file options, avoid zip bombs vulnerability attack - Typo fix for documentation and error message --- sheetpr.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'sheetpr.go') diff --git a/sheetpr.go b/sheetpr.go index 8bc4bfe..6f46040 100644 --- a/sheetpr.go +++ b/sheetpr.go @@ -182,14 +182,14 @@ func (o *AutoPageBreaks) getSheetPrOption(pr *xlsxSheetPr) { // AutoPageBreaks(bool) // OutlineSummaryBelow(bool) func (f *File) SetSheetPrOptions(name string, opts ...SheetPrOption) error { - sheet, err := f.workSheetReader(name) + ws, err := f.workSheetReader(name) if err != nil { return err } - pr := sheet.SheetPr + pr := ws.SheetPr if pr == nil { pr = new(xlsxSheetPr) - sheet.SheetPr = pr + ws.SheetPr = pr } for _, opt := range opts { @@ -208,11 +208,11 @@ func (f *File) SetSheetPrOptions(name string, opts ...SheetPrOption) error { // AutoPageBreaks(bool) // OutlineSummaryBelow(bool) func (f *File) GetSheetPrOptions(name string, opts ...SheetPrOptionPtr) error { - sheet, err := f.workSheetReader(name) + ws, err := f.workSheetReader(name) if err != nil { return err } - pr := sheet.SheetPr + pr := ws.SheetPr for _, opt := range opts { opt.getSheetPrOption(pr) -- cgit v1.2.1