From 2df615fa2831bd578371d4e3606f16461c474ce7 Mon Sep 17 00:00:00 2001 From: xuri Date: Thu, 20 Oct 2022 00:02:30 +0800 Subject: This close #1373, fixes the incorrect build-in number format apply the result - An error will be returned when setting the stream row without ascending row numbers, to avoid potential mistakes as mentioned in #1139 - Updated unit tests --- stream_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'stream_test.go') diff --git a/stream_test.go b/stream_test.go index c399d63..a4a0590 100644 --- a/stream_test.go +++ b/stream_test.go @@ -61,7 +61,7 @@ func TestStreamWriter(t *testing.T) { }})) assert.NoError(t, streamWriter.SetRow("A6", []interface{}{time.Now()})) assert.NoError(t, streamWriter.SetRow("A7", nil, RowOpts{Height: 20, Hidden: true, StyleID: styleID})) - assert.EqualError(t, streamWriter.SetRow("A7", nil, RowOpts{Height: MaxRowHeight + 1}), ErrMaxRowHeight.Error()) + assert.EqualError(t, streamWriter.SetRow("A8", nil, RowOpts{Height: MaxRowHeight + 1}), ErrMaxRowHeight.Error()) for rowID := 10; rowID <= 51200; rowID++ { row := make([]interface{}, 50) @@ -77,7 +77,7 @@ func TestStreamWriter(t *testing.T) { assert.NoError(t, file.SaveAs(filepath.Join("test", "TestStreamWriter.xlsx"))) // Test set cell column overflow. - assert.ErrorIs(t, streamWriter.SetRow("XFD1", []interface{}{"A", "B", "C"}), ErrColumnNumber) + assert.ErrorIs(t, streamWriter.SetRow("XFD51201", []interface{}{"A", "B", "C"}), ErrColumnNumber) // Test close temporary file error. file = NewFile() @@ -226,6 +226,9 @@ func TestStreamSetRow(t *testing.T) { streamWriter, err := file.NewStreamWriter("Sheet1") assert.NoError(t, err) assert.EqualError(t, streamWriter.SetRow("A", []interface{}{}), newCellNameToCoordinatesError("A", newInvalidCellNameError("A")).Error()) + // Test set row with non-ascending row number + assert.NoError(t, streamWriter.SetRow("A1", []interface{}{})) + assert.EqualError(t, streamWriter.SetRow("A1", []interface{}{}), newStreamSetRowError(1).Error()) } func TestStreamSetRowNilValues(t *testing.T) { -- cgit v1.2.1