diff options
author | xuri <xuri.me@gmail.com> | 2021-08-15 00:06:40 +0800 |
---|---|---|
committer | xuri <xuri.me@gmail.com> | 2021-08-15 00:06:40 +0800 |
commit | 48c16de8bf74df0fa94a30d29e2e7e3446d48433 (patch) | |
tree | 329a2e4ab896982581bd348a1700d75aeb40a517 /sheetpr.go | |
parent | f6f14f507ee1adf4883cb1b12f27932a63afb286 (diff) |
Improve security and simplify code
- Make variable name more semantic
- Reduce cyclomatic complexities for the formula calculate function
- Support specified unzip size limit on open file options, avoid zip bombs vulnerability attack
- Typo fix for documentation and error message
Diffstat (limited to 'sheetpr.go')
-rw-r--r-- | sheetpr.go | 10 |
1 files changed, 5 insertions, 5 deletions
@@ -182,14 +182,14 @@ func (o *AutoPageBreaks) getSheetPrOption(pr *xlsxSheetPr) { // AutoPageBreaks(bool) // OutlineSummaryBelow(bool) func (f *File) SetSheetPrOptions(name string, opts ...SheetPrOption) error { - sheet, err := f.workSheetReader(name) + ws, err := f.workSheetReader(name) if err != nil { return err } - pr := sheet.SheetPr + pr := ws.SheetPr if pr == nil { pr = new(xlsxSheetPr) - sheet.SheetPr = pr + ws.SheetPr = pr } for _, opt := range opts { @@ -208,11 +208,11 @@ func (f *File) SetSheetPrOptions(name string, opts ...SheetPrOption) error { // AutoPageBreaks(bool) // OutlineSummaryBelow(bool) func (f *File) GetSheetPrOptions(name string, opts ...SheetPrOptionPtr) error { - sheet, err := f.workSheetReader(name) + ws, err := f.workSheetReader(name) if err != nil { return err } - pr := sheet.SheetPr + pr := ws.SheetPr for _, opt := range opts { opt.getSheetPrOption(pr) |